Fold input system/developer messages into native provider system param#48
Conversation
Greptile SummaryThis PR fixes a correctness bug where
Confidence Score: 5/5Safe to merge — the change is a straightforward correctness fix that promotes previously-dropped content into the system prompt, all three provider paths are symmetric and unit-tested. All three provider converters follow the same well-tested pattern. The text-extraction helpers in convert_utils are simple and correct. No existing behavior is removed — only silent data loss is eliminated. The Azure strip_gateway_fields addition mirrors an already-proven pattern from the OpenAI adapter. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["convert_responses_input_to_messages(input, instructions)"] --> B["Seed system_parts with instructions"]
B --> C{input present?}
C -- No --> Z["join_system_parts(system_parts)"]
C -- Yes --> D{input variant}
D -- Text --> E["Push single user message"] --> Z
D -- Items --> F["Iterate items"]
F --> G{item type}
G -- "EasyMessage(System|Developer)" --> H["easy_content_text()"] --> I["Push to system_parts"] --> F
G -- "MessageItem(System|Developer)" --> J["input_content_text()"] --> K["Push to system_parts"] --> F
G -- "EasyMessage(User|Assistant)" --> L["Push to messages list"] --> F
G -- "MessageItem(User)" --> M["Push to messages list"] --> F
G -- other --> F
Z --> N["Return (Option<SystemPrompt>, Vec<Message>)"]
E --> N
subgraph "convert_utils.rs"
H
J
end
Reviews (4): Last reviewed commit: "Merge branch 'main' into fix/native-syst..." | Re-trigger Greptile |
No description provided.