Improve parsing of gem install flag patterns to reduce false positives#954
Merged
lorenzo merged 1 commit intohadolint:masterfrom Apr 24, 2024
mkusaka:patch
Merged
Improve parsing of gem install flag patterns to reduce false positives#954lorenzo merged 1 commit intohadolint:masterfrom mkusaka:patch
lorenzo merged 1 commit intohadolint:masterfrom
mkusaka:patch
Conversation
extra flags without equal sign and double dashes: RUN gem install bundler:2.0.1 -- --use-system-libraries true extra flags without double dashes: RUN gem install bundler:2.0.1 --use-system-libraries true extra flags without double dashes with equal sign: RUN gem install bundler:2.0.1 --use-system-libraries=true
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
In Hadolint, there are several gem install flag patterns that result in false positives.
Warnings should not be displayed for the following patterns:
In this PR, I have made adjustments so that these patterns can also be parsed correctly.
How I did it
I modified the processing to remove options and their subsequent arguments from the list of arguments.
How to verify it
I have added tests related to the additional patterns.