Correct documentation example for failure-threshold#901
Merged
lorenzo merged 1 commit intohadolint:masterfrom Nov 16, 2022
ericcornelissen:patch-1
Merged
Correct documentation example for failure-threshold#901lorenzo merged 1 commit intohadolint:masterfrom ericcornelissen:patch-1
failure-threshold#901lorenzo merged 1 commit intohadolint:masterfrom
ericcornelissen:patch-1
Conversation
Fix an example snippet for `failure-threshold` that was both: - Invalid (incorrect syntax) - Incorrect (there's no top-level configuration option "warning" or "info")
Member
|
thanks so much! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix an example snippet for
failure-thresholdthat was both:How I did it
Update the example based on how the configuration should be according to the rest of the documentation and verify the syntax with the first tool I could fine online.
How to verify it
Copy the snippet into a configuration file and see if it 1) works now and 2) didn't work before.