fix(DL3029): allow BUILDPLATFORM and TARGETPLATFORM variables#867
Merged
lorenzo merged 1 commit intohadolint:masterfrom Nov 7, 2022
Merged
Conversation
3365a82 to
f2f5c4c
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861
What I did
Allowed
BUILDPLATFORMandTARGETPLATFORMinFROM --plaform=How I did it
Updated the existing rule to check if the value contains one of the variables. This is the lazy way without getting into complex regex.
How to verify it
I added new tests, but I have not been able to run anything. I tried to use
nix-shellto get a development environment, but the compilation is never ending. This is also my first time touching Haskell code, so I barely understand a quarter of the changes I made 😅