DL3049: Fix behaviour with multistage builds#852
Merged
lorenzo merged 1 commit intohadolint:masterfrom Jul 9, 2022
Merged
Conversation
- Fix DL3049 behaviour with multistage builds In a multistage build, when a stage has an alias, it is reasonable to assume that it will not be the last stage in the build process. Rather there will be another stage inheriting or copying from that stage. Therefore required labels don't necessarily need to be present in the stage with the alias. fixes: hadolint#758 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multistage build, when a stage has an alias, it is reasonable to
assume that it will not be the last stage in the build process. Rather
there will be another stage inheriting or copying from that stage.
Therefore required labels don't necessarily need to be present in the
stage with the alias.
fixes: #758
Signed-off-by: Moritz Röhrich moritz.rohrich@suse.com