DL3057: fix multiple warnings for multistage builds#851
Merged
lorenzo merged 1 commit intohadolint:masterfrom Jul 9, 2022
Merged
DL3057: fix multiple warnings for multistage builds#851lorenzo merged 1 commit intohadolint:masterfrom
lorenzo merged 1 commit intohadolint:masterfrom
Conversation
DL3057 checks that images produced in multistage builds have a healthcheck (if the rule is enabled). But if one stage already has the healthcheck instruction, the other stages should not trigger a warning. If the stage comes earlier, it's obviously not used as a build result, therefore doesn't need a healthcheck instruction on its own. If the stage comes later, it will inherit the healthcheck instruction from the stage that has it. This fix works because when a healthcheck is found in a build stage, that stage is marked as good, but also all stages it inherited from are also marked as good. Only stages that don't inherit the healthcheck instruction remain marked as bad, if they don't have the instruction themselves. Therefore Dockerfiles, which produce multiple images are also considered. fixes: hadolint#843 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DL3057 checks that images produced in multistage builds have a
healthcheck (if the rule is enabled). But if one stage already has the
healthcheck instruction, the other stages should not trigger a warning.
If the stage comes earlier, it's obviously not used as a build result,
therefore doesn't need a healthcheck instruction on its own.
If the stage comes later, it will inherit the healthcheck instruction
from the stage that has it.
This fix works because when a healthcheck is found in a build stage,
that stage is marked as good, but also all stages it inherited from are
also marked as good. Only stages that don't inherit the healthcheck
instruction remain marked as bad, if they don't have the instruction
themselves. Therefore Dockerfiles, which produce multiple images are
also considered.
fixes: #843
Signed-off-by: Moritz Röhrich moritz.rohrich@suse.com
How to verify it
This does not trigger DL3057 at all anymore:
This triggers for the last stage only: