DL3013: Fix false positives for VCS, http and local path packages (#389)#845
Merged
lorenzo merged 2 commits intohadolint:masterfrom Jul 9, 2022
Merged
DL3013: Fix false positives for VCS, http and local path packages (#389)#845lorenzo merged 2 commits intohadolint:masterfrom
lorenzo merged 2 commits intohadolint:masterfrom
Conversation
added 2 commits
June 15, 2022 22:37
…dolint#389) - Fix false positive when installing package with other supported VCS such as: `pip install bzr+ssh://..@1.0.0`, as described in https://pip.pypa.io/en/stable/topics/vcs-support/. - Fix false positive when installing package from local directory: `pip install my/install/path` - Fix false positive when installing package from http/https url: `pip install https://foo.bar/baz-1.0.0.zip`
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
such as:
pip install bzr+ssh://..@1.0.0, as described inhttps://pip.pypa.io/en/stable/topics/vcs-support/.
pip install my/install/pathpip install https://foo.bar/baz-1.0.0.zipfixes #389
How I did it
Extended the previous check for a
git+httpsvcs scheme to allow any of the supported vcs sources, such asgit+sshandbzr+ssh, documented in https://pip.pypa.io/en/stable/topics/vcs-support/. Also added passing check if a package source included a forward slash (/) but is not a valid vcs source.How to verify it
Compare the supported VCS in this PR from the VCS supported from the pip documentation https://pip.pypa.io/en/stable/topics/vcs-support/. Also, the following Dockerfile illustrates cases where hadolint now runs without any warnings.