Skip to content

DL3022 support for copying from images#815

Merged
lorenzo merged 1 commit intohadolint:masterfrom
Wirone:DL3022-support-images
Apr 7, 2022
Merged

DL3022 support for copying from images#815
lorenzo merged 1 commit intohadolint:masterfrom
Wirone:DL3022-support-images

Conversation

@Wirone
Copy link
Copy Markdown
Contributor

@Wirone Wirone commented Apr 6, 2022

According to discussion in #197 I've tried to provide improvement for DL3022. I don't know if it works, info below.

What I did

Tried to implement @lorenzo'a suggestion 😉

How I did it

Blindfoldly 😆

How to verify it

Probably stack test. I couldn't verify it because I coudn't get it to work:

$ stack test
(...)
hspec-core> [40 of 40] Compiling Test.Hspec.Core.Runner
hspec-core> /usr/bin/ld.gold: error: cannot find -ltinfo
hspec-core> collect2: error: ld returned 1 exit status
hspec-core> `gcc' failed in phase `Linker'. (Exit code: 1)
Progress 1/4

--  While building package hspec-core-2.9.4 (scroll up to its section to see the error) using:
      /home/codito/.stack/setup-exe-cache/x86_64-linux-tinfo6/Cabal-simple_mPHDZzAJ_3.2.1.0_ghc-8.10.7 --builddir=.stack-work/dist/x86_64-linux-tinfo6/Cabal-3.2.1.0 build --ghc-options " -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1

I just thought I will create a PR and see what happens in Github Actions.

@Wirone Wirone marked this pull request as draft April 6, 2022 23:33
@Wirone Wirone force-pushed the DL3022-support-images branch from ab70d77 to 391a278 Compare April 6, 2022 23:40
@Wirone Wirone force-pushed the DL3022-support-images branch from 391a278 to 2eeab96 Compare April 7, 2022 06:49
@lorenzo lorenzo marked this pull request as ready for review April 7, 2022 07:40
@Wirone Wirone changed the title Draft: DL3022 support for copying from images DL3022 support for copying from images Apr 7, 2022
@lorenzo
Copy link
Copy Markdown
Member

lorenzo commented Apr 7, 2022

Thanks!

@lorenzo lorenzo merged commit bc2dd5b into hadolint:master Apr 7, 2022
@Wirone Wirone deleted the DL3022-support-images branch April 7, 2022 08:03
@mwgamble mwgamble mentioned this pull request Oct 12, 2022
Closed
This was referenced Feb 9, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wirone @lorenzo