DL3061: fix false positive on pragmas#797
Merged
lorenzo merged 1 commit intohadolint:masterfrom Mar 18, 2022
Merged
Conversation
- Fix false positive error DL3061 when encountering a pragma before a `FROM` instruction. In particular `# syntax = docker/dockerfile...` but also `# shell = ...` pragmas can appear before the first `FROM` instruction without error. fixes: hadolint#795
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FROMinstruction.In particular
# syntax = docker/dockerfile...but also# shell = ...pragmas can appear before the first
FROMinstruction without error.fixes: #795
How to verify it
This should no longer produce false positive error DL3061 messages:
Thanks to @aaronfi-procore and @subodhdharma for reporting this issue.