DL3026: Trusted registries wildcard domains#767
Merged
lorenzo merged 1 commit intohadolint:masterfrom Feb 25, 2022
Merged
Conversation
Adds support for trusted registry domain wildcards. Private registries like Artifactory use sub-domain for Docker registries so this will allow users to allow any repository under a single domain (`*.megacorp.com`). Refs hadolint#630
Member
|
thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for trusted registry domain wildcards. Private registries like
Artifactory use sub-domain for Docker registries so this will allow users to
allow any repository under a single domain (
--trusted-registry "*.megacorp.com").Refs #630
How I did it
Modified DL3026 isAllowed to search the registries set for entries that are either prefixed or suffixed with "*". For those
entries the item is matched as a suffix or prefix respectively.
This is my very first attempt at Haskell, so please let me know if there is a better way to go about it.
How to verify it
Tests have been added to
DL3026Spectho validate the matching rules.