DL3038, DL3040, DL3041: Add support for microdnf#764
Merged
lorenzo merged 1 commit intohadolint:masterfrom Feb 25, 2022
Merged
Conversation
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added so all rules concerning dnf (DL3038, DL3040, DL3041) works analogously for microdnf as well, which closes #742. Note that I have not updated any documentation for the corresponding rule changes, since I wasn't sure if and how this should be done.
How I did it
Added utility function
cmdsHaveArgs :: [Text.Text] -> [Text.Text] -> Command -> BoolinShell.hs, which is a generalized version of the functioncmdHasArgs. The function has been used to check for the rules concerned in this PR.How to verify it
Test cases have been added so running the tests should be good enough. One can also run hadolint with the following file:
which outputs:
Note that all warnings says
dnfand notmicrodnf.