Skip to content

Bring env var for trusted registries in sync with docs (#756)#759

Merged
lorenzo merged 1 commit intohadolint:masterfrom
evhan:trusted-registries-env-var
Feb 25, 2022
Merged

Bring env var for trusted registries in sync with docs (#756)#759
lorenzo merged 1 commit intohadolint:masterfrom
evhan:trusted-registries-env-var

Conversation

@evhan
Copy link
Copy Markdown
Contributor

@evhan evhan commented Jan 4, 2022

What I did

Renamed the configuration variable from HADOLINT_{ALLOWED => TRUSTED}_REGISTRIES in order to match the documented behaviour.

Closes #756.

How I did it

Just changed the relevant variable string values.

Didn't update any of the procedure names, since they still seem correct; they are still handling the list of allowed registries.

How to verify it

Run:

HADOLINT_TRUSTED_REGISTRIES=good.example.com hadolint /dev/stdin <<< 'FROM bad.example.org/image:v1.0'

Expected output:

/dev/stdin:1 DL3026 error: Use only an allowed registry in the FROM image

@lorenzo
Copy link
Copy Markdown
Member

lorenzo commented Feb 25, 2022

thanks

@lorenzo lorenzo merged commit 0b128a9 into hadolint:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting HADOLINT_TRUSTED_REGISTRIES has no effect

2 participants