Add pyproject and hook to auto download github releases#1152
Open
IamTheFij wants to merge 2 commits intohadolint:masterfrom
Open
Add pyproject and hook to auto download github releases#1152IamTheFij wants to merge 2 commits intohadolint:masterfrom
IamTheFij wants to merge 2 commits intohadolint:masterfrom
Conversation
This will force any forks to continue to download releases from upstream unless they change the URL
0671e11 to
143ea06
Compare
Author
|
Actually, it looks like I forgot to tell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #886
What I did
I've added a
pyproject.tomland a new hook that will allowpre-committo installhadolintbinaries using pip. I've done something similar for StyLua.How I did it
I had to make an update to
release-gitterto add version parsing from*.cabalfiles, but with thatHow to verify it
I added a test to
release-gitterthat runs off my fork that validate this.I also tested by adding the following to a repo of mine with pre-commit:
It successfully downloaded and ran the checks.