DL3041, DL3033: Handle RPM package with plus sign#1125
Merged
m-ildefons merged 1 commit intohadolint:masterfrom Sep 15, 2025
Merged
DL3041, DL3033: Handle RPM package with plus sign#1125m-ildefons merged 1 commit intohadolint:masterfrom
m-ildefons merged 1 commit intohadolint:masterfrom
Conversation
m-ildefons
approved these changes
Sep 11, 2025
Member
m-ildefons
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added to Hadolint rule DL3041 and DL3033 to allow plus signs for a.) package names which contain a hyphen and b.) versioning.
How I did it
Updated DL3033.hs
isVersionCharallowable characters to allow '+'Updated DL3041.hs
isVersionCharallowable characters '+'Added tests to DL3033Spec.hs for package name with hyphen and plus sign.
Added tests to DL3041Spec.hs for package name with hyphen and plus sign.
How to verify it
Unit Tests:
All unit tests pass successfully