fix(DL3041): Prevent false negatives for packages which include a dash in their package name#1098
Merged
m-ildefons merged 2 commits intohadolint:masterfrom Aug 15, 2025
Conversation
…h in their package name Tries to validate presence of a version based on the following assumptions: - At least one "-" must be present - All dash-separated parts after the first must contain only valid version characters (according to Fedora Versioning Guidelines) - At least one dash-separated part after the first must start with a digit Fixes hadolint#1002
m-ildefons
approved these changes
Aug 14, 2025
Member
m-ildefons
left a comment
There was a problem hiding this comment.
Hi Florian,
thanks for the contribution. It looks pretty good and I'd accept it.
I've put some suggestions, since you asked for it. But don't take them too harshly, they are pretty nit-picky.
…e a dash in their package name
Contributor
Author
Thanks! That really helps. I tried to address your feedback with a follow-up commit, please have a look :) |
Member
|
Great. Thanks a lot for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Prevent false negatives for packages which include a dash in their package name
How I did it
Tries to validate presence of a version based on the following assumptions:
How to verify it
Unit tests included
Fixes #1002
Please note that this is my first time writing Haskell, so please suggest changes if there are better ways to do this.