DL3048 accepting LABEL keys that contain underscore(s) or slash(es)#1034
DL3048 accepting LABEL keys that contain underscore(s) or slash(es)#1034m-ildefons merged 1 commit intohadolint:masterfrom
Conversation
Underscores and slashes should be accepted as part of a LABEL key. See https://docs.docker.com/engine/manage-resources/labels/#key-format-recommendations
|
From your own link (the guidelines following the main body):
i.e. while underscores (_) and slashes (/) are technically allowed, you shouldn't use them |
|
I agree, you should not use them. But it does not say, you may not use them. First sentence in the Docker Docs: https://docs.docker.com/engine/manage-resources/labels/#key-format-recommendations A label key is the left-hand side of the key-value pair. Keys are alphanumeric strings which may contain periods (.), underscores (), slashes (/), and hyphens (-)._ So, either merge or decline. |
|
First of all: this is a linter, the intention is helping to build best practice Docker images, not just valid ones. |
Underscores and slashes should be accepted as part of a LABEL key. See https://docs.docker.com/engine/manage-resources/labels/#key-format-recommendations
What I did
How I did it
How to verify it