Skip to content

Ignore unsatisfiable shellcheck error 1091#1020

Merged
lorenzo merged 1 commit intohadolint:masterfrom
ghoneycutt:ignore_sc1091
Mar 5, 2025
Merged

Ignore unsatisfiable shellcheck error 1091#1020
lorenzo merged 1 commit intohadolint:masterfrom
ghoneycutt:ignore_sc1091

Conversation

@ghoneycutt
Copy link
Copy Markdown
Contributor

@ghoneycutt ghoneycutt commented May 31, 2024

This check is related to SC1090 which is already skipped in PR #344 and background in issue #343.

What I did

Add SC1091 to list of shellcheck entries to ignore.

Why I did it

Because SC1090 and SC1091 are essentially the same and SC1090 is already excluded.

How I did it

Simple addition to existing list.

How to verify it

Use this Dockerfile

FROM alpine:3
RUN . /etc/sysconfig/somefile

before

$ hadolint Dockerfile
Dockerfile:2 SC1091 info: Not following: File not included in mock.

after

~/.local/bin/hadolint Dockerfile ; echo $?
0

This check is related to SC1090 which is already skipped in PR hadolint#344
and background in issue hadolint#343.
@ghoneycutt ghoneycutt marked this pull request as draft May 31, 2024 22:27
@ghoneycutt ghoneycutt marked this pull request as ready for review May 31, 2024 22:35
@markholland
Copy link
Copy Markdown

Came across this today. Tried adding it to .hadolint.yaml ignored list but now VSCode complains that SC1091 isn't in the yaml-schema for hadolint.

@lorenzo
Copy link
Copy Markdown
Member

lorenzo commented Mar 5, 2025

thanks

@lorenzo lorenzo merged commit f8fa217 into hadolint:master Mar 5, 2025
@markholland
Copy link
Copy Markdown

When will this be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants