Skip to content

Submit value propagation fix#118

Merged
haacked merged 4 commits intomainfrom
haacked/117-submit-value-propagation-fix
Aug 8, 2024
Merged

Submit value propagation fix#118
haacked merged 4 commits intomainfrom
haacked/117-submit-value-propagation-fix

Conversation

@haacked
Copy link
Owner

@haacked haacked commented Aug 7, 2024

In order to propagate the submit button value, this library creates a hidden input which was introduced in #50. However, we were bad children and we didn't clean up after ourselves. In this PR, we clean it up.

Fixes #117

Copy link

@lukearnould lukearnould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@haacked haacked merged commit b8b9965 into main Aug 8, 2024
@haacked haacked deleted the haacked/117-submit-value-propagation-fix branch August 8, 2024 07:09
@lukearnould
Copy link

@haacked do you plan to publish a new Git release for this version or are there other changes you're waiting to aggregate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Method of submit value propagation makes certain workflows impossible

3 participants