Skip to content

MAINT: Add nightly wheel upload#2355

Merged
tacaswell merged 4 commits intoh5py:masterfrom
larsoner:nightly
Feb 23, 2024
Merged

MAINT: Add nightly wheel upload#2355
tacaswell merged 4 commits intoh5py:masterfrom
larsoner:nightly

Conversation

@larsoner
Copy link
Copy Markdown
Contributor

@larsoner larsoner commented Dec 12, 2023

Closes #2353

Trying to use https://github.com/git-for-windows/get-azure-pipelines-artifact for now but in case it doesn't work the direct JSON queries don't seem too bad actually.

Needs:

  • Get artifact working properly
  • Repackage properly
  • Remove TODO / uncomment lines
  • @tacaswell add secrets.ANACONDA_ORG_UPLOAD_TOKEN

Then should be good to merge.

@larsoner
Copy link
Copy Markdown
Contributor Author

@tacaswell based on https://github.com/h5py/h5py/actions/runs/7186963572/job/19573501403?pr=2355#step:7:58 I think I just need to take care of the TODO uncommenting steps and you need to add the secret, then we can merge and 🤞 . Does that sound right to you?

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de331ae) 89.53% compared to head (6732f05) 89.53%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          17       17           
  Lines        2380     2380           
=======================================
  Hits         2131     2131           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tacaswell
Copy link
Copy Markdown
Member

Finally looked at this, and realized I do not have the ability to generate these tokens like I thought I did. Working on sorting out who does.

@tacaswell
Copy link
Copy Markdown
Member

I've added the secret, but we can not test this with out merging so I'm going to go ahead and merge it.

@tacaswell tacaswell merged commit be73418 into h5py:master Feb 23, 2024
@tacaswell
Copy link
Copy Markdown
Member

@larsoner Something is not going right with the "download the wheels" step.

@tacaswell
Copy link
Copy Markdown
Member

@larsoner
Copy link
Copy Markdown
Contributor Author

I am really confused because looking at what the URL the action uses:

https://dev.azure.com/h5pyappveyor/h5py/_apis/build/builds?definitions=1&statusFilter=completed&resultFilter=succeeded&reasonFilter=individualCI&$top=1

I get a nice 1-count list that points to the right build. And then over in #2383 things are fine. Maybe just try restarting the CIs again?

@tacaswell
Copy link
Copy Markdown
Member

I re-ran the action this morning and it worked!

I suspect I was too impatient and tried running the action before azure had fully finished so maybe I was losing the race.

Sorry for the noise....

@larsoner
Copy link
Copy Markdown
Contributor Author

No problem, awesome that it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numpy 2.0 compat plan

2 participants