Skip to content

Conversation

@mattbrundage
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coliff
Copy link
Member

coliff commented Mar 19, 2019

I'm not sure about this. This doesn't make the CSS anymore performant or particularly easier to read - but then it's not a big deal either way as it was nearly alphabetical anyway.

Generally though, I find the suggestions on http://codeguide.co/#css-declaration-order (by MDO, co-creator of Bootstrap and Senior Director of Design at GitHub) the best advice for ordering property declarations.

@mattbrundage
Copy link
Contributor Author

Fair enough. However, this file's property declaration order doesn't conform to the code guide that you cited -- rather, it suggests an alphabetic approach. Hence my pull request.

@roblarsen
Copy link
Member

roblarsen commented Mar 19, 2019

I don't think we ever had a public discussion of the order of the properties in the project CSS. Which is kind of surprising, but I don't remember it ever coming up.

I don't follow any pattern at all in my personal or (!!) professional development so I don't have a stake in this game at all.

It would be good to have a pattern.

Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my opinion on this after researching the topic. :-) I approve of this change now.

@roblarsen roblarsen merged commit ca144b7 into h5bp:master Mar 21, 2019
@Jeroen-Matthijssens
Copy link
Contributor

Jeroen-Matthijssens commented Mar 21, 2019

@coliff I'd be interested to know what changed your mind and what your opinion is on css property ordering. Or could you perhaps give me some links to articles you found interesting on this topic?

ps: Sorry only saw your other post after i posted this. (#16 (comment))

@mattbrundage mattbrundage deleted the patch-1 branch March 21, 2019 15:30
@coliff coliff mentioned this pull request Apr 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants