invalidation logic for cached query results re-worked #4262
+532
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandinj
reviewed
Aug 22, 2025
|
|
||
| /** | ||
| * Collect all database objects, this command depends on | ||
| * @return Set of dependencies |
Contributor
There was a problem hiding this comment.
"this command depends on" .... ?
:-)
Contributor
Author
There was a problem hiding this comment.
Please correct it, if you think it is not a proper English, but this sounds ok to me, although I am not a native speaker 😄
Contributor
Author
|
Unfortunately newly added test TestCachedQueryResults still failing occasionally, so looks like some gremlins are still lurking around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4208
Most likely also fix #4255