GH-4133: Fix remaining query cache after ddl #4261
Merged
+188
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #4133.
There's problem that cached queries are remaining after DDL execution. It causes confusion that already modified or removed objects are remaining.
It can be fixed by clear cache after DDL query exection.
Changes
Clear query caches after DDL execution.
I think, There were 2 ways to implement this logic.
Modify DefineCommand.java that is parent of DDL commands.
I don't think it's a good idea because there are 2 problems. First, too many modification needed. And, complex structure neede to change modificationMetaId.
h2database/h2/src/main/org/h2/engine/Database.java
Line 167 in 2df8bdc
Modify Database.java.
It solves both of the above problems.
Add integration tests.
Database.java is hard to implement unit test. So, I add integration tests that can be asserted.