Improve NON_KEYWORDS and other changes #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NON_KEYWORDSsetting now works in more cases, for example,ROWnow can be used as a column name withNON_KEYWORDS=ROW. Closes "ROW" cannot be set as a non keyword in 2.x #3390.FILTERis removed from the list of context-sensitive keywords, because now onlyFILTER (WHEREhas special meaning.SpatialDataTypeare changed fromObjecttoSpatialto reduce number of casts.Spatialis an interface fromMVStore, so it can be used here without introduction of unwanted dependencies.Objectwas needed a long time ago to avoid usage ofSpatialKeyfrom H2.DbObject.getCreateSQLForCopy()now has default implementation that throws an exception to significantly reduce number of its implementations, most of them also need to throw an exception.Database.getTempTableName()now truncates too long names of identifiers.ADMINprivileges like any other DDL operations with user-provided classes.