Assorted fixes #2836
Assorted fixes #2836
Conversation
| } | ||
| if (!hasColumn) { | ||
| throw DbException.getSyntaxError(sqlStatement, sqlStatement.length(), | ||
| "Valid MERGE INTO statement with at least one updatable column"); |
There was a problem hiding this comment.
It is what we expect and not what we found.
There was a problem hiding this comment.
Yes, we expect to "have at least one updateable column", but we did not find that.
So we should say
"Valid MERGE INTO statement requires at least one updatable column"
or
"MERGE INTO statement without at least one updatable column"
There was a problem hiding this comment.
The whole error message is:
Syntax error in SQL statement "MERGE INTO T0(C0) KEY(C1) VALUES (1)[*]"; expected "Valid MERGE INTO statement with at least one updatable column"
There was a problem hiding this comment.
It don't want to allocate a new error code for the normal error message for this specific corner case in non-standard command. This command has significant design problems, it can't handle GENERATED ALWAYS identity columns and generated columns well.
Closes #2831.
Closes #2833.
Closes #2835.
Also contains unrelated changes in value classes. Some code is moved from
ValuetoValueStringBaseandValueInterval.