A number of small configuration-related changes#163
Merged
guyfedwards merged 4 commits intoguyfedwards:masterfrom Oct 9, 2025
larsks:feature/mostly-config-updates
Merged
A number of small configuration-related changes#163guyfedwards merged 4 commits intoguyfedwards:masterfrom larsks:feature/mostly-config-updates
guyfedwards merged 4 commits intoguyfedwards:masterfrom
larsks:feature/mostly-config-updates
Conversation
Owner
|
Got some conflicts @larsks, thanks |
By making `setupConfigDir` a method on `*Config`, we don't need to recompute the config file path; we can just read it from `c.ConfigPath`. Similarly, we can use `c.ConfigDir` rather than passing the directory in as a parameter.
When the argument to `--config-path` is a directory, join the default config
file name to the directory name. That is, if you run:
nom -c foo
Nom will act as if you actually ran:
nom -c foo/config.yml
When looking for a full-featured editor in environment variables, it is common to first check `$VISUAL` and then `$EDITOR`.
Contributor
Author
|
I've resolve the conflicts. Cheers! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a number of minor updates, mostly centered around configuration handling:
The only real operational change is that now
nomwill attempt to correct for the case when you pass a directory as the argument to--config-path. This is an easy mistake to make when tab completion is involved.