fix: Fix config path handling#161
Merged
guyfedwards merged 1 commit intoguyfedwards:masterfrom Oct 2, 2025
larsks:fix/config-path
Merged
fix: Fix config path handling#161guyfedwards merged 1 commit intoguyfedwards:masterfrom larsks:fix/config-path
guyfedwards merged 1 commit intoguyfedwards:masterfrom
larsks:fix/config-path
Conversation
The config handling code was erroneously including the path separator in
arguments to `filepath.Join`, like this:
configFile := filepath.Join(configDir, "/config.yml")
When running nom against a config file in the current directory:
nom --config-path config.yml
This would result in `configDir` equal to `""`, and `configFile` would get
set to `/config.yml`. This commit updates the path handling code to
correctly use `filepath.Join`. It also replaces string splitting on paths
with `filepath.Split`.
We also add a `-c` short option for setting the configuration path:
nom -c config.yml
Owner
|
Thanks @larsks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config handling code was erroneously including the path separator in arguments to
filepath.Join, like this:When running nom against a config file in the current directory:
This would result in
configDirequal to"", andconfigFilewould get set to/config.yml. This commit updates the path handling code to correctly usefilepath.Join. It also replaces string splitting on paths withfilepath.Split.We also add a
-cshort option for setting the configuration path: