Update getting-started.md by janiceilene · Pull Request #1985 · gulpjs/gulp

janiceilene · 2017-07-10T18:22:40Z

No description provided.

phated

Followed up

phated · 2017-07-12T22:38:00Z

docs/getting-started.md


 *If you've previously installed gulp globally, run `npm rm --global gulp` before following these instructions.*

+*Make sure that you've installed Node and NPM before attempting to install gulp.*


Should this be a separate step? It seems to blend with the other notice.

phated · 2017-07-12T22:38:20Z

docs/getting-started.md

@@ -2,12 +2,21 @@

 *If you've previously installed gulp globally, run `npm rm --global gulp` before following these instructions.*


Should this be the place where we point to the Gulp Sip article or further below?

I think it should go here. In the part below, I think you want people focusing on npm and node installation.

phated · 2017-07-12T22:38:38Z

docs/getting-started.md

 #### Install the `gulp` command

 ```sh
 npm install --global gulp-cli


It might make sense to mention the Sip in this section instead?

I think the other one's better.

phated · 2017-07-12T22:39:19Z

docs/getting-started.md

 ```

+#### Create a package.json
+If you don't have a package.json, create one. If you need help, run an npm init which will walk you through giving it a name, version, and description.


wrap package.json in code ticks. Same with npm init; should probably say "etc" of things it walks through.

phated · 2017-07-12T22:39:31Z

docs/getting-started.md

+If you don't have a package.json, create one. If you need help, run an npm init which will walk you through giving it a name, version, and description.
+
+```sh
+npm init


Is this needed if it's above?

Agreed. Deleted.

phated · 2017-07-12T22:39:48Z

docs/getting-started.md

 #### Create a `gulpfile`

-Create a file called `gulpfile.js` in your project root with these contents:
+In your project directory create a file called `gulpfile.js` in your project root with these contents:


comma after "In your project directory"

"called" -> "named"?

phated · 2017-07-12T22:40:34Z

docs/getting-started.md


+#### Result
+
 Voila! The default task will run and do nothing.


How does this happen?

What do you mean? Isn't all of this just magic?

Missed a part, this is fine.

phated · 2017-07-12T22:40:54Z

docs/getting-started.md

 Voila! The default task will run and do nothing.

+```sh
+Using gulpfile ~/gulp/gulpfile.js


Change /gulp/ to my-project?

phated · 2017-07-12T22:41:16Z

docs/getting-started.md

+[11:15:51] Finished 'default' after 103 μs
+```
+
 To run multiple tasks, you can use `gulp <task> <othertask>`.


Does this help or confuse?

No idea whether it helps or confuses, because I don't really know what it means. Maybe a screenshot instead? Or we could just delete it? Do people know what it should look like when it "does nothing"?

This should be moved into "Test it out" section

phated · 2017-07-12T22:41:33Z

docs/getting-started.md

+
 To run multiple tasks, you can use `gulp <task> <othertask>`.

 ## Where do I go now?


Want to do any improvements to this section?

phated · 2017-07-19T18:56:48Z

docs/getting-started.md

 # Getting Started

-*If you've previously installed gulp globally, run `npm rm --global gulp` before following these instructions.*
+*If you've [previously installed](https://medium.com/gulpjs/gulp-sips-command-line-interface-e53411d4467) gulp globally, run `npm rm --global gulp` before following these instructions.*


I don't like "previously installed" as the link text

phated · 2017-07-19T18:57:28Z

docs/getting-started.md

+#### Check for Node and npm
+Make sure that you've installed Node and npm before attempting to install gulp.
+
+```node --version```


I think we should have the npm --version command also.

phated · 2017-07-19T19:02:30Z

docs/getting-started.md


+#### Result
+
 Voila! The default task will run and do nothing.


Missed a part, this is fine.

phated · 2017-07-19T19:02:52Z

docs/getting-started.md

+[11:15:51] Finished 'default' after 103 μs
+```
+
 To run multiple tasks, you can use `gulp <task> <othertask>`.


This should be moved into "Test it out" section

phated · 2017-07-19T20:54:11Z

Thanks!

Update getting-started.md

b8d068d

phated requested changes Jul 12, 2017

View reviewed changes

janiceilene added 3 commits July 12, 2017 21:36

Update getting-started.md

9e0cbb8

Update getting-started.md

7e720b6

Updated descriptions of Where do I go

6733ca0

phated requested changes Jul 19, 2017

View reviewed changes

janiceilene added 2 commits July 19, 2017 12:03

Update getting-started.md

d61b3e0

Made changes based on comments

dd99c48

phated approved these changes Jul 19, 2017

View reviewed changes

phated merged commit c95e09e into gulpjs:master Jul 19, 2017


		If you've previously installed gulp globally, run `npm rm --global gulp` before following these instructions.

		Make sure that you've installed Node and NPM before attempting to install gulp.

		@@ -2,12 +2,21 @@

		If you've previously installed gulp globally, run `npm rm --global gulp` before following these instructions.


		To run multiple tasks, you can use `gulp <task> <othertask>`.

		## Where do I go now?

Uh oh!

Conversation

janiceilene commented Jul 10, 2017

Uh oh!

phated left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phated commented Jul 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants