Add "Rollup with rollup-stream" recipe.#1690
Merged
phated merged 2 commits intogulpjs:masterfrom Jun 19, 2016
lemmabit:recipe-rollup-stream
Merged
Add "Rollup with rollup-stream" recipe.#1690phated merged 2 commits intogulpjs:masterfrom lemmabit:recipe-rollup-stream
phated merged 2 commits intogulpjs:masterfrom
lemmabit:recipe-rollup-stream
Conversation
| // transform the code further here. | ||
|
|
||
| // if you want to output with a different name from the input file, use gulp-rename here. | ||
| // .pipe(rename('index.js')) |
Member
There was a problem hiding this comment.
indentation is off here. Should this just be removed?
Contributor
Author
There was a problem hiding this comment.
I put the // at the start of the line so it would line up with the other .pipes. I'll change it if you want, but I prefer it this way myself.
Member
There was a problem hiding this comment.
It looks really weird when I view the rich diff. Align it with the // transform the code further here. line
Contributor
Author
|
Alright, the indentation has been adjusted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is essentially the same as the first two examples from rollup-stream's README.md. Once rollup-plugin-gulp earns the right to exist by having unit tests, I'll add a recipe for its use together with rollup-stream. That's assuming rollup-plugin-gulp turns out to be a good idea and not a horrifying aberration, of course.