Feat: adds proxy agent for NVDA installation request #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be good to add an e2e test / example to https://github.com/guidepup/setup/blob/main/.github/workflows/test.yml where we set a value for the env var and see a successful installation |
Contributor
That said, such a test would be quite involved afaik, requiring to write a local test proxy server… https://www.npmjs.com/package/https-proxy-agent is very battle tested so don’t expect any issues, there’s just no guarantee this won’t be accidentally regressed as is. Let’s go with it for now and come back for it if required. |
cmorten
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
No issue found.
Details
Until now it was not possible to download NVDA on windows when using a proxy.
CheckList