Merged
Conversation
When pipenv dumps the lock file to a requirements.txt, it does not include the `sys_platform` directive. This causes pip to attempt to install win32 packages, which fails. By using `pypenv sync --system` instead, only packages applicable to Linux are installed. Fixes #1993
This reduces the size of the AppImage by 7.4%
ilija-lazoroski
approved these changes
Jun 9, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2007 +/- ##
===========================================
- Coverage 56.50% 56.48% -0.02%
===========================================
Files 463 465 +2
Lines 12985 13025 +40
===========================================
+ Hits 7337 7357 +20
- Misses 5648 5668 +20
Continue to review full report at Codecov.
|
shreyamalviya
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1993
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Have you checked that you haven't introduced any duplicate code?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working