refactor(rename): Update enum names to conventional case

guanguans · guanguans · commit 87792760b214 · 2026-02-02T21:32:26.000+08:00
- Renamed enum from Suit to Enum for consistency.
- Adjusted case names to follow conventional casing.
- Updated references in the fixture to reflect new enum structure.
diff --git a/composer.json b/composer.json
@@ -244,8 +244,8 @@
             "@putenv:php",
             "$PHP82 vendor/bin/grumphp run --ansi -vv"
         ],
-        "jack": "@php vendor/bin/jack --ansi -vv",
-        "jack:breakpoint": "@jack breakpoint --limit=8",
+        "jack": "@php -d='error_reporting=E_ALL &~ E_DEPRECATED' vendor/bin/jack",
+        "jack:breakpoint": "@jack breakpoint --limit=9",
         "jack:breakpoint-dev": "@jack:breakpoint --dev",
         "jack:open-versions": "@jack open-versions --limit=99",
         "jack:open-versions-dev": "@jack:open-versions --dev",
diff --git a/src/Rector/Name/RenameToConventionalCaseNameRector.php b/src/Rector/Name/RenameToConventionalCaseNameRector.php
@@ -547,8 +547,8 @@ private function shouldUcfirstCamelName(Node $node): bool
                 Trait_::class,
                 // enum EnumName{}
                 Enum_::class,
-                // enum Enum{case CaseName;}
-                EnumCase::class,
+                // // enum Enum{case CaseName;}
+                // EnumCase::class,
             ])
         ) {
             return true;
@@ -653,6 +653,8 @@ private function shouldUpperSnakeName(Node $node): bool
                 Const_::class,
                 // Foo::CONST_NAME;
                 ClassConstFetch::class,
+                // enum Enum{case CASE_NAME;}
+                EnumCase::class,
             ])
         ) {
             return true;
diff --git a/tests/Rector/AbstractRectorTestCase.php b/tests/Rector/AbstractRectorTestCase.php
@@ -92,7 +92,7 @@ final public static function provideCases(): iterable
     {
         yield from self::yieldFilesFromDirectory(static::directory().'/Fixture/');
 
-        foreach ((array) glob(static::directory().'/Fixture[0-9]*/', \GLOB_ONLYDIR) as $directory) {
+        foreach ((array) glob(static::directory().'/Fixture\d*/', \GLOB_ONLYDIR) as $directory) {
             if ((int) (\PHP_MAJOR_VERSION.\PHP_MINOR_VERSION) >= (int) (string) Str::of($directory)->basename()->substr(7)) {
                 yield from self::yieldFilesFromDirectory($directory);
             }
diff --git a/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture81/fixture.php.inc b/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture81/fixture.php.inc
@@ -3,13 +3,11 @@
 /** @noinspection ALL */
 // @formatter:off
 // phpcs:ignoreFile
-enum Suit: string
+enum Enum: string
 {
-    case Heart = 'Heart';
-    case Diamond = 'Diamond';
-    case Club = 'Club';
+    case CaseName = 'CaseName';
 }
-Suit::Heart;
+Enum::CaseName;
 
 ?>
 -----
@@ -18,12 +16,10 @@ Suit::Heart;
 /** @noinspection ALL */
 // @formatter:off
 // phpcs:ignoreFile
-enum Suit: string
+enum Enum: string
 {
-    case Heart = 'Heart';
-    case Diamond = 'Diamond';
-    case Club = 'Club';
+    case CASE_NAME = 'CaseName';
 }
-Suit::HEART;
+Enum::CASE_NAME;
 
 ?>

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ final public static function provideCases(): iterable`
`92`	`92`	`{`
`93`	`93`	`yield from self::yieldFilesFromDirectory(static::directory().'/Fixture/');`
`94`	`94`
`95`		`- foreach ((array) glob(static::directory().'/Fixture[0-9]*/', \GLOB_ONLYDIR) as $directory) {`
	`95`	`+ foreach ((array) glob(static::directory().'/Fixture\d*/', \GLOB_ONLYDIR) as $directory) {`
`96`	`96`	`if ((int) (\PHP_MAJOR_VERSION.\PHP_MINOR_VERSION) >= (int) (string) Str::of($directory)->basename()->substr(7)) {`
`97`	`97`	`yield from self::yieldFilesFromDirectory($directory);`
`98`	`98`	`}`