fix(rename): Enhance parameter renaming logic for promoted variables

guanguans · guanguans · commit 7d80f74784eb · 2026-02-01T19:44:46.000+08:00
- Add check to skip renaming for promoted parameters in function-like nodes.
- Improve handling of variable nodes to prevent unnecessary renaming.
diff --git a/src/Rector/FunctionLike/RenameGarbageParamNameRector.php b/src/Rector/FunctionLike/RenameGarbageParamNameRector.php
@@ -25,15 +25,18 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\FunctionLike;
 use PhpParser\Node\Param;
+use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Foreach_;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
+use PHPStan\Reflection\ClassReflection;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\BetterPhpDocParser\ValueObject\PhpDocAttributeKey;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\DeadCode\NodeAnalyzer\ExprUsedInNodeAnalyzer;
 use Rector\PhpParser\Enum\NodeGroup;
 use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PHPStan\ScopeFetcher;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 
 /**
@@ -204,6 +207,9 @@ private function refactorForeach(Foreach_ $foreachNode): ?Foreach_
         )) ? $foreachNode : null;
     }
 
+    /**
+     * @throws \Rector\Exception\ShouldNotHappenException
+     */
     private function refactorFunctionLike(FunctionLike $functionLikeNode): ?FunctionLike
     {
         $hasChanged = false;
@@ -214,6 +220,8 @@ private function refactorFunctionLike(FunctionLike $functionLikeNode): ?Function
         foreach ($functionLikeNode->getParams() as $paramNode) {
             if (
                 !$paramNode->var instanceof Variable
+                || $paramNode->isPromoted()
+                || $this->hasPrototypeMethod($functionLikeNode)
                 || $this->isUsedVariable($functionLikeNode, $paramNode->var)
             ) {
                 continue;
@@ -235,6 +243,28 @@ private function refactorFunctionLike(FunctionLike $functionLikeNode): ?Function
         return $hasChanged ? $functionLikeNode : null;
     }
 
+    /**
+     * @throws \Rector\Exception\ShouldNotHappenException
+     */
+    private function hasPrototypeMethod(FunctionLike $functionLikeNode): bool
+    {
+        if (!$functionLikeNode instanceof ClassMethod) {
+            return false;
+        }
+
+        $classReflection = ScopeFetcher::fetch($functionLikeNode)->getClassReflection();
+
+        if (!$classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        try {
+            return $classReflection->getNativeReflection()->getMethod($this->getName($functionLikeNode))->hasPrototype();
+        } catch (\ReflectionException $reflectionException) {
+            return false;
+        }
+    }
+
     private function isUsedVariable(FunctionLike $node, Variable $variableNode): bool
     {
         // Skip abstract, interface, empty body function like and foreach.
diff --git a/tests/Rector/FunctionLike/RenameGarbageParamNameRector/Fixture/skips.php.inc b/tests/Rector/FunctionLike/RenameGarbageParamNameRector/Fixture/skips.php.inc
@@ -12,3 +12,23 @@ interface Bar
     // Skip interface method.
     public function run($param): void;
 }
+
+class Baz
+{
+    // Skip promoted property parameter.
+    public function __construct(private Bar $bar)
+    {
+    }
+}
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+
+final class FooRector extends AbstractRector
+{
+    // Skip has prototype method.
+    public function refactor(Node $node): ?Node
+    {
+        return null;
+    }
+}
