fix(renaming): Ensure scope attribute is set for variable nodes

guanguans · guanguans · commit 379d6389a620 · 2026-01-22T15:17:54.000+08:00
- Add a check to ensure the scope attribute is set on nodes.
- If the scope is not an instance of Scope, fetch and set it from the parent node.
- This change improves the handling of node attributes in the renaming process.
diff --git a/composer.json b/composer.json
@@ -377,7 +377,7 @@
         "rector:process-clear-cache": "@rector:process --clear-cache",
         "rector:process-clear-cache-dry-run": "@rector:process-clear-cache --dry-run",
         "rector:process-dry-run": "@rector:process --dry-run",
-        "rector:process-only": "@rector:process-clear-cache tests.php --only=Guanguans\\RectorRules\\Rector\\FuncCall\\RenameAppFunctionToResolveFunctionRector",
+        "rector:process-only": "@rector:process-clear-cache tests.php --only=Guanguans\\RectorRules\\Rector\\Name\\RenameToConventionalCaseNameRector",
         "rector:process-only-dry-run": "@rector:process-only --dry-run",
         "rule-doc-generator": [
             "@putenv:php",
diff --git a/rector.php b/rector.php
@@ -71,7 +71,7 @@
     // ->withoutParallel()
     ->withParallel()
     // ->withImportNames(importDocBlockNames: false, importShortClasses: false)
-    ->withImportNames(true, false, false)
+    // ->withImportNames(true, false, false)
     // ->withImportNames(importNames: false)
     // ->withEditorUrl()
     ->withFluentCallNewLine()
diff --git a/src/Rector/Name/RenameToConventionalCaseNameRector.php b/src/Rector/Name/RenameToConventionalCaseNameRector.php
@@ -184,6 +184,8 @@ public function getNodeTypes(): array
      *
      * @param \PhpParser\Node\Expr\FuncCall|\PhpParser\Node\Expr\Variable|\PhpParser\Node\Identifier|\PhpParser\Node\Name $node
      *
+     * @throws \Rector\Exception\ShouldNotHappenException
+     *
      * @noinspection BadExceptionsProcessingInspection
      */
     public function refactor(Node $node): ?Node
@@ -376,6 +378,8 @@ class Foo{public int $propertyName;}
      * @see \Rector\Renaming\Collector\RenamedNameCollector
      *
      * @param \PhpParser\Node\Expr\FuncCall|\PhpParser\Node\Expr\Variable|\PhpParser\Node\Identifier|\PhpParser\Node\Name $node
+     *
+     * @throws \Rector\Exception\ShouldNotHappenException
      */
     private function rename(Node $node, callable $renamer): ?Node
     {
@@ -404,21 +408,26 @@ private function rename(Node $node, callable $renamer): ?Node
             }
 
             /**
+             * ```
+             * function func_name($var_name): void {}
+             * ```
              * In the `\PhpParser\Node\FunctionLike` parameter,
              * the `\PhpParser\Node\Expr\Variable` node does not have a scope attribute,
-             * and even if it is renamed, `rector` will report an error.
-             *
-             * "System error: "Node "PhpParser\Node\Expr\Variable" with is missing scope required for scope refresh"
+             * and even if it is renamed, `rector` will report an error:
              * ```
-             * function func_name($var_name): void {}
+             * System error: "Node "PhpParser\Node\Expr\Variable" with is missing scope required for scope refresh
              * ```.
+             *
+             * So we fetch from parent node to set the scope attribute.
              */
             if ($node instanceof Variable && !$node->getAttribute(AttributeKey::SCOPE) instanceof Scope) {
-                throw new RectorErrorException(
-                    $this,
-                    "The variable name [$node->name] cannot be renamed to [$newName] because of missing scope.",
-                    $node->getAttributes()
-                );
+                // throw new RectorErrorException(
+                //     $this,
+                //     "The variable name [$node->name] cannot be renamed to [$newName] because of missing scope.",
+                //     $node->getAttributes()
+                // );
+                $parent = $node->getAttribute('parent');
+                $parent instanceof Node and $node->setAttribute(AttributeKey::SCOPE, ScopeFetcher::fetch($parent));
             }
 
             $node->name = $newName;
@@ -757,7 +766,7 @@ private function wrapRenamer(callable $renamer, Node $node): \Closure
                 }
 
                 // if the name is all uppercase letters, convert it to lowercase letters.
-                if (ctype_upper(preg_replace('/[^a-zA-Z]/', '', $name))) {
+                if (preg_match('/^[A-Z_]+$/', $name)) {
                     return Str::lower($name);
                 }
 
diff --git a/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture/fixture_variable_scope.php.inc b/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture/fixture_variable_scope.php.inc
@@ -4,8 +4,7 @@
 
 /**
  * In the `\PhpParser\Node\FunctionLike` parameter,
- * the `\PhpParser\Node\Expr\Variable` node does not have a scope attribute,
- * and even if it is renamed, `rector` will report an error.
+ * the `\PhpParser\Node\Expr\Variable` node does not have a scope attribute.
  */
 function func_name(string $var_name): string
 {
@@ -22,10 +21,9 @@ function func_name(string $var_name): string
 
 /**
  * In the `\PhpParser\Node\FunctionLike` parameter,
- * the `\PhpParser\Node\Expr\Variable` node does not have a scope attribute,
- * and even if it is renamed, `rector` will report an error.
+ * the `\PhpParser\Node\Expr\Variable` node does not have a scope attribute.
  */
-function func_name(string $var_name): string
+function func_name(string $varName): string
 {
     $newVarName = $varName;
 
