refactor(name): Preserve enum member types during renaming

guanguans · guanguans · commit 0e5f03c459c5 · 2026-02-02T00:37:15.000+08:00
- Add condition to skip renaming for identifiers within enum classes when the type is 'int' or 'string'
- Ensure renaming does not alter enum member types, maintaining code consistency and correctness
diff --git a/src/Rector/Name/RenameToConventionalCaseNameRector.php b/src/Rector/Name/RenameToConventionalCaseNameRector.php
@@ -760,6 +760,14 @@ private function shouldLcfirstCamelName(Node $node): bool
     private function wrapRenamer(callable $renamer, Node $node): \Closure
     {
         return function (string $name) use ($node, $renamer): string {
+            if (
+                $node instanceof Identifier
+                && $node->getAttribute('parent') instanceof Enum_
+                && $this->isNames($node, ['int', 'string'])
+            ) {
+                return $name;
+            }
+
             if (str_contains($name, '::')) {
                 [$className, $constantOrMethodName] = Str::of($name)
                     ->explode('::', 2)
diff --git a/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture81/fixture.php.inc b/tests/Rector/Name/RenameToConventionalCaseNameRector/Fixture81/fixture.php.inc
@@ -3,15 +3,12 @@
 /** @noinspection ALL */
 // @formatter:off
 // phpcs:ignoreFile
-
 enum Suit: string
 {
     case Heart = 'Heart';
     case Diamond = 'Diamond';
     case Club = 'Club';
-    case Spade = 'Spade';
 }
-
 Suit::Heart;
 
 ?>
@@ -21,15 +18,12 @@ Suit::Heart;
 /** @noinspection ALL */
 // @formatter:off
 // phpcs:ignoreFile
-
 enum Suit: string
 {
     case Heart = 'Heart';
     case Diamond = 'Diamond';
     case Club = 'Club';
-    case Spade = 'Spade';
 }
-
-Suit::Heart;
+Suit::HEART;
 
 ?>
