fix(ExceptionMustImplementNativeThrowableRule): Improve type assertion for nativeThrowable

guanguans · guanguans · commit 17d8273e4de5 · 2026-02-05T01:44:39.000+08:00
- Change assertion from is_subclass_of to is_a for stricter type checking
- Ensures that the provided nativeThrowable is a valid instance of Throwable
diff --git a/baselines/loader.neon b/baselines/loader.neon
@@ -1,4 +1,4 @@
-# total 8 errors
+# total 9 errors
 
 includes:
     - phpstanApi.runtimeReflection.neon
diff --git a/baselines/phpstanApi.runtimeReflection.neon b/baselines/phpstanApi.runtimeReflection.neon
@@ -4,10 +4,10 @@ parameters:
     ignoreErrors:
         -
             message: '#^Function is_a\(\) is a runtime reflection concept that might not work in PHPStan because it uses fully static reflection engine\. Use objects retrieved from ReflectionProvider instead\.$#'
-            count: 1
+            count: 2
             path: ../src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php
 
         -
             message: '#^Function is_subclass_of\(\) is a runtime reflection concept that might not work in PHPStan because it uses fully static reflection engine\. Use objects retrieved from ReflectionProvider instead\.$#'
-            count: 3
+            count: 2
             path: ../src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php
diff --git a/baselines/rector.noInstanceOfStaticReflection.neon b/baselines/rector.noInstanceOfStaticReflection.neon
@@ -1,8 +1,8 @@
-# total 1 error
+# total 2 errors
 
 parameters:
     ignoreErrors:
         -
             message: '#^Instead of "instanceof/is_a\(\)" use ReflectionProvider service or "\(new ObjectType\(\<desired_type\>\)\)\-\>isSuperTypeOf\(\<element_type\>\)" for static reflection to work$#'
-            count: 1
+            count: 2
             path: ../src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php
diff --git a/src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php b/src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php
@@ -40,7 +40,7 @@ final class ExceptionMustImplementNativeThrowableRule extends AbstractMixedNodeT
      */
     public function __construct(string $nativeThrowable)
     {
-        \assert(is_subclass_of($nativeThrowable, \Throwable::class));
+        \assert(is_a($nativeThrowable, \Throwable::class, true));
         $this->nativeThrowable = $nativeThrowable;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 8 errors`
	`1`	`+# total 9 errors`
`2`	`2`
`3`	`3`	`includes:`
`4`	`4`	`- phpstanApi.runtimeReflection.neon`
Original file line number	Diff line number	Diff line change
`@@ -4,10 +4,10 @@ parameters:`
`4`	`4`	`ignoreErrors:`
`5`	`5`	`-`
`6`	`6`	`message: '#^Function is_a\(\) is a runtime reflection concept that might not work in PHPStan because it uses fully static reflection engine\. Use objects retrieved from ReflectionProvider instead\.$#'`
`7`		`- count: 1`
	`7`	`+ count: 2`
`8`	`8`	`path: ../src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php`
`9`	`9`
`10`	`10`	`-`
`11`	`11`	`message: '#^Function is_subclass_of\(\) is a runtime reflection concept that might not work in PHPStan because it uses fully static reflection engine\. Use objects retrieved from ReflectionProvider instead\.$#'`
`12`		`- count: 3`
	`12`	`+ count: 2`
`13`	`13`	`path: ../src/Rule/Class_/ExceptionMustImplementNativeThrowableRule.php`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ final class ExceptionMustImplementNativeThrowableRule extends AbstractMixedNodeT`
`40`	`40`	`*/`
`41`	`41`	`public function __construct(string $nativeThrowable)`
`42`	`42`	`{`
`43`		`- \assert(is_subclass_of($nativeThrowable, \Throwable::class));`
	`43`	`+ \assert(is_a($nativeThrowable, \Throwable::class, true));`
`44`	`44`	`$this->nativeThrowable = $nativeThrowable;`
`45`	`45`	`}`
`46`	`46`