refactor(Process): replace PhpExecutableFinder with PhpSubprocess

guanguans · guanguans · commit d62a3f21024c · 2026-02-10T14:53:27.000+08:00
- Simplified the process initialization by using PhpSubprocess.
- Improved readability and maintainability of the code.
- Ensured compatibility with the existing functionality.
diff --git a/composer-dependency-analyser.php b/composer-dependency-analyser.php
@@ -15,12 +15,7 @@
 use ShipMonk\ComposerDependencyAnalyser\Config\ErrorType;
 
 return (new Configuration)
-    ->addPathsToScan(
-        [
-            // __DIR__.'/src/',
-        ],
-        false
-    )
+    // ->addPathsToScan([__DIR__.'/config/'], false)
     ->addPathsToExclude([
         __DIR__.'/src/Foundation/Rectors/',
         __DIR__.'/src/Foundation/Support/ComposerScripts.php',
diff --git a/composer.json b/composer.json
@@ -363,7 +363,7 @@
         "peck:init": "@peck --init",
         "pest": [
             "@putenv:xdebug-on",
-            "@php vendor/bin/pest --colors=always --min=60 --coverage --profile",
+            "@php vendor/bin/pest --colors=always --min=80 --coverage --profile",
             "@putenv:xdebug-off"
         ],
         "pest:coverage": "@pest --coverage-html=.build/phpunit/ --coverage-clover=.build/phpunit/clover.xml",
diff --git a/monorepo-builder.php b/monorepo-builder.php
@@ -22,8 +22,7 @@
 use Symfony\Component\Console\Output\ConsoleOutput;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\Process\ExecutableFinder;
-use Symfony\Component\Process\PhpExecutableFinder;
-use Symfony\Component\Process\Process;
+use Symfony\Component\Process\PhpSubprocess;
 use Symplify\MonorepoBuilder\Config\MBConfig;
 use Symplify\MonorepoBuilder\Contract\Git\TagResolverInterface;
 use Symplify\MonorepoBuilder\Git\BranchAwareTagResolver;
@@ -64,17 +63,8 @@
         // PushNextDevReleaseWorker::class,
     ]);
 
-    if (
-        \PHP_MAJOR_VERSION === 8 && \PHP_MINOR_VERSION === 1
-        && !(new ArgvInput)->hasParameterOption('--dry-run', true)
-    ) {
-        (new Process([
-            (new PhpExecutableFinder)->find(),
-            (new ExecutableFinder)->find($composer = 'composer', $composer),
-            'run',
-            'checks:required',
-            '--ansi',
-        ]))
+    if (!(new ArgvInput)->hasParameterOption('--dry-run', true)) {
+        (new PhpSubprocess([(new ExecutableFinder)->find('composer'), 'run', 'checks:required', '--ansi']))
             ->setEnv(['COMPOSER_MEMORY_LIMIT' => -1])
             ->setTimeout(600)
             ->mustRun(static function (string $_, string $buffer): void {
