Summary

Fixes Electron Desktop terminal startup on macOS by ensuring node-pty's prebuilt spawn-helper has executable permissions and by hardening shell resolution.

The failure appeared as posix_spawnp failed when starting the desktop terminal. The root cause was that the node-pty prebuild spawn-helper binary was unpacked without executable permissions after npm ci.

What Changed

• Ensure node-pty spawn-helper prebuilds are executable before terminal startup.
• Extract shell resolution into apps/desktop/electron/terminal-shell.cjs.
• Prefer a valid absolute shell path from SHELL, falling back to macOS shell defaults.
• Add terminal startup diagnostics for shell path, cwd, env, platform, and file mode.
• Add tests for valid shell selection, invalid shell fallback, and executable absolute-path resolution.

Validation

• npm run type-check --workspace apps/desktop — PASS
• npm run build --workspace apps/desktop — PASS
• npm run test:desktop:platforms --workspace apps/desktop — 79 PASS
• node --test apps/desktop/electron/terminal-shell.test.cjs — 13 PASS
• Electron dev restart: posix_spawnp failed no longer appears

Scope

• Desktop terminal startup only.
• No API timeout changes.
• No OpenRouter/proxy changes.
• No Browser Workspace / executors / Kanban changes.