Fix SetMetadata to preserve existing GCP instance metadata#1657
Merged
james00012 merged 1 commit intomainfrom Jan 28, 2026
Merged
Fix SetMetadata to preserve existing GCP instance metadata#1657james00012 merged 1 commit intomainfrom
james00012 merged 1 commit intomainfrom
Conversation
The newMetadata function was not preserving existing metadata items when adding new key-value pairs. This caused SetMetadata and AddSshKey to replace all instance metadata instead of merging. Fixes #1655
aa4042e to
5b58d39
Compare
thisguycodes
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newMetadatato preserve existing metadata items when adding new key-value pairsnewMetadatafunctionProblem
Since v0.55.0,
SetMetadataandAddSshKeyreplaced all instance metadata instead of merging new items with existing ones.Solution
Modified
newMetadatato first copy existing metadata items, then add/update with new key-value pairs.Fixes #1655