Fix various bugs and cleanup deprecated code#1646
Merged
james00012 merged 12 commits intomainfrom Dec 26, 2025
Merged
Conversation
- Replace golang.org/x/net/context with standard library context - Replace ioutil.ReadFile with os.ReadFile in k8s config tests
- Fix database rows defer before nil check (would panic on error) - Fix docker multierror.Append missing first argument - Fix slack returning wrong error type (was fmt.Errorf, should be MessageNotFoundErr)
- Fix swapped VPC filter constants (resourceTypeFilterName/resourceIdFilterName) - Fix PutECRRepoPolicy calling wrong function (was calling PutECRRepoLifecyclePolicyE)
- Fix database rows defer before nil check (would panic on error) - Fix docker multierror.Append missing first argument - Fix slack returning wrong error type (was fmt.Errorf, should be MessageNotFoundErr)
- Fix newMetadata appending to wrong slice (was appending to oldMetadata.Items instead of items) - Fix error variable shadowing in GetAllGcpRegionsE callback - Fix error variable shadowing in GetAllGcpZonesE callback
- Fix overly permissive directory permissions (0777 -> 0755) - Remove dead code in lambda.go (unreachable error check) - Fix off-by-one error in collections stringslicevalue
- Fix typos in AWS module (region.go, s3.go, rds.go) - Fix typos in Azure module (errors.go, compute.go, nsg.go, frontdoor.go, loadbalancer.go) - Fix typos in GCP module (gcr.go, storage.go, compute.go) - Fix typos in K8s module (errors.go, pod.go) - Fix typos in Terraform module (errors.go)
- Fix newMetadata appending to wrong slice (was appending to oldMetadata.Items instead of items) - Fix error variable shadowing in GetAllGcpRegionsE callback - Fix error variable shadowing in GetAllGcpZonesE callback
- Fix overly permissive directory permissions (0777 -> 0755) - Remove dead code in lambda.go (unreachable error check) - Fix off-by-one error in collections stringslicevalue
…in/fix/aws-critical-bugs', 'origin/fix/gcp-critical-bugs', 'origin/fix/doc-typos' and 'origin/fix/code-quality' into fix/v1-cleanup
This was referenced Dec 25, 2025
Closed
Closed
- Fix SSH agent defer-in-loop resource leak (move defer inside goroutine) - Fix GCP storage missing error handling for object deletion - Fix typos in Azure compute and nsg modules
denis256
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes
Cleanup
golang.org/x/net/context→context,ioutil→os)