Fix order of ExtraArgs for Output command with non-empty key (fixes #1606)#1607
Merged
james00012 merged 2 commits intogruntwork-io:mainfrom Oct 26, 2025
Merged
Conversation
james00012
approved these changes
Oct 26, 2025
Contributor
james00012
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making this change.
Contributor
|
You may have to click the "update branch". |
Contributor
|
Verified relevant tests are passing as well 👍 |
Contributor
Author
|
53 minutes. That is a record time-to-merge that I have ever seen. Thank you @james00012! Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1606.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Fix order of ExtraArgs for Output command with non-empty key.