Skip to content

Fix order of ExtraArgs for Output command with non-empty key (fixes #1606)#1607

Merged
james00012 merged 2 commits intogruntwork-io:mainfrom
dee-kryvenko:tf-output-extra-args-order
Oct 26, 2025
Merged

Fix order of ExtraArgs for Output command with non-empty key (fixes #1606)#1607
james00012 merged 2 commits intogruntwork-io:mainfrom
dee-kryvenko:tf-output-extra-args-order

Conversation

@dee-kryvenko
Copy link
Copy Markdown
Contributor

Description

Fixes #1606.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Fix order of ExtraArgs for Output command with non-empty key.

Copy link
Copy Markdown
Contributor

@james00012 james00012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change.

@james00012
Copy link
Copy Markdown
Contributor

You may have to click the "update branch".

@james00012
Copy link
Copy Markdown
Contributor

Verified relevant tests are passing as well 👍

Copy link
Copy Markdown
Contributor

@james00012 james00012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james00012 james00012 merged commit e011dc7 into gruntwork-io:main Oct 26, 2025
2 checks passed
@dee-kryvenko
Copy link
Copy Markdown
Contributor Author

53 minutes. That is a record time-to-merge that I have ever seen. Thank you @james00012! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExtraArgs Output wrong order

2 participants