Ensuring that multiple dummy servers can use the same handlers#1603
Merged
james00012 merged 2 commits intogruntwork-io:mainfrom Oct 26, 2025
Merged
Conversation
0413797 to
0853bb5
Compare
yhakbar
approved these changes
Oct 25, 2025
Contributor
yhakbar
left a comment
There was a problem hiding this comment.
LGTM as well. @james00012 are you willing to merge this and release it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1602.
Replaced the default
http.HandleFuncwith a uniqueServeMuxfor each instance.Added a test that confirms the right behavior.
Nothing gets broken nor any behavior changes. Except for the bug I've filed earlier.
TODOs
Read the Gruntwork contribution guidelines.
^ I've read that, but I'm still kinda lost about all the things below v.v Sorry v.v
Release Notes (draft)
RunDummyServerWithHandlersEnow uses a unique ServeMux each.Migration Guide
None needed.