Updated the subnet struct and corresponding function to fetch the subnet CIDR range#1561
Merged
james00012 merged 1 commit intogruntwork-io:mainfrom Jun 2, 2025
Merged
Conversation
james00012
approved these changes
Jun 2, 2025
Contributor
james00012
left a comment
There was a problem hiding this comment.
LGTM the failing test doesn't seem to be related to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
1.Updated subnet struct to include CIDR block variable
2.Updated the function GetSubnetsForVpcE to assign the CIDR block value to the struct variable before returning.
By this update users can fetch the subnet CIDR along with the other details for writing tests, particularly this is usefull when user trying to check if the CIDR allocated to the created subnet is expected or not with out writing any extra code.