Don't merge stderr to stdout#1495
Merged
james00012 merged 2 commits intogruntwork-io:mainfrom Jan 6, 2025
Merged
Conversation
`RunTerraformCommandAndGetStdoutE` actually returns stdout and stderr combined. This commit fixes that.
Contributor
|
Failing test doesn't seem to be related to this change. LGTM |
Contributor
|
Please "update branch" in order to merge this PR. @g7r |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunTerraformCommandAndGetStdoutEactually returns stdout and stderr combined. This commit fixes that.Terragrunt and Terraform output their warnings to stderr. Commands like
terraform output -jsonandterraform show -jsonare especially vulnerable to keeping their output clean.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
RunTerraformCommandAndGetStdoutEno longer merges stderr to its result.