Skip to content

Don't merge stderr to stdout#1495

Merged
james00012 merged 2 commits intogruntwork-io:mainfrom
g7r:dont-merge-stderr-to-stdout
Jan 6, 2025
Merged

Don't merge stderr to stdout#1495
james00012 merged 2 commits intogruntwork-io:mainfrom
g7r:dont-merge-stderr-to-stdout

Conversation

@g7r
Copy link
Copy Markdown
Contributor

@g7r g7r commented Dec 25, 2024

RunTerraformCommandAndGetStdoutE actually returns stdout and stderr combined. This commit fixes that.

Terragrunt and Terraform output their warnings to stderr. Commands like terraform output -json and terraform show -json are especially vulnerable to keeping their output clean.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

  • fix: RunTerraformCommandAndGetStdoutE no longer merges stderr to its result.

`RunTerraformCommandAndGetStdoutE` actually returns stdout and stderr
combined. This commit fixes that.
@g7r g7r requested a review from denis256 as a code owner December 25, 2024 12:22
@james00012 james00012 self-assigned this Jan 1, 2025
@james00012
Copy link
Copy Markdown
Contributor

Failing test doesn't seem to be related to this change. LGTM

Copy link
Copy Markdown
Contributor

@james00012 james00012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james00012
Copy link
Copy Markdown
Contributor

Please "update branch" in order to merge this PR. @g7r

Copy link
Copy Markdown
Contributor

@james00012 james00012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james00012 james00012 merged commit 0721fbe into gruntwork-io:main Jan 6, 2025
@g7r g7r deleted the dont-merge-stderr-to-stdout branch January 6, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants