Merged
Conversation
denis256
approved these changes
Dec 12, 2024
| func RunCommandAndGetStdOutErrE(t testing.TestingT, command Command) (stdout string, stderr string, err error) { | ||
| output, err := runCommand(t, command) | ||
| if err != nil { | ||
| return output.Stdout(), output.Stderr(), &ErrWithCmdOutput{err, output} |
Member
There was a problem hiding this comment.
'output' might have 'nil' value?
In some cases can be returned error and nil...
https://github.com/gruntwork-io/terratest/blob/main/modules/shell/command.go#L109
it may require to change in multiple places
Contributor
Author
There was a problem hiding this comment.
Got it. Will address this in a follow-up PR.
Contributor
Author
There was a problem hiding this comment.
Looking at the code again, it is actually safe for output to be nil since it will return empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1228.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide