feat(Azure): add new check for private DNS zones#1455
Merged
james00012 merged 4 commits intogruntwork-io:mainfrom Jan 23, 2025
Merged
feat(Azure): add new check for private DNS zones#1455james00012 merged 4 commits intogruntwork-io:mainfrom
james00012 merged 4 commits intogruntwork-io:mainfrom
Conversation
denis256
reviewed
Oct 22, 2024
Contributor
Author
|
@denis256 I have implemented your comments, please review. |
Contributor
Author
|
@denis256 Could you have a look? |
Contributor
|
Hi @johannes-engler-mw, I can help to trigger relevant tests for this change. |
Contributor
Author
|
Hi @james03160927, i have fixed the merge conflict. Please retrigger the tests. |
Contributor
|
Hi @johannes-engler-mw, can you modify the title to remove WIP since it's already being reviewed? |
Contributor
Author
|
@james03160927 I have run my new tests and they where successful. |
james00012
approved these changes
Jan 20, 2025
Contributor
james00012
left a comment
There was a problem hiding this comment.
LGTM. Can you update the branch with the latest change merged in main? You can just click the button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds #1454 .
This PR adds an assertion helper for Azure Private DNS Zones.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for Azure Private DNS Zones assertion helpers.