This repository was archived by the owner on Apr 9, 2021. It is now read-only.
update tutorial with static/dynamic info#197
Merged
Conversation
Updated tutorial to reflect the new static/dynamic code generation options in Node. Will need to wait til the next release to merge though as the links are all to the most recent release, which doesn't have the new examples... (they're in master)
Member
|
The relevant release has been published and the examples are there: https://github.com/grpc/grpc/tree/release-0_14/examples/node Otherwise, the changes LGTM |
Author
|
Ah, ok, I think the variable the site is using in links is still sending everything to the 0_13 release, should we change that? |
Member
|
I think that would be a good thing to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tutorial to reflect the new static/dynamic code generation options in Node. Will need to wait til the next release to merge though as the links are all to the most recent release, which doesn't have the new examples... (they're in master)