Add missing BUILD rules for service config proto.#74
Merged
easwars merged 1 commit intogrpc:masterfrom Feb 11, 2020
Merged
Conversation
Member
|
What needs to use this? |
Contributor
Author
|
There is no active user of this. But the fact that when I made a change to the proto, there was no way to verify that my changes would build. That's the reason. |
Member
So the short answer is actually "travis": This means it's working, as these lines do not appear in the master build. |
dfawley
approved these changes
Feb 10, 2020
ejona86
approved these changes
Feb 10, 2020
Member
ejona86
left a comment
There was a problem hiding this comment.
Dependencies need to be exposed via a helper library so that downstream users can pull in the expected versions. But this dependency is not needed by downstream users unless they use service config. Once we actually need this dependency downstream we'll need to create a helper library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.