grpc-js: Make pick_first use exitIdle#2619
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.9.xfrom Nov 16, 2023
Merged
grpc-js: Make pick_first use exitIdle#2619murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.9.xfrom
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.9.xfrom
Conversation
gnossen
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug described in #1490 (comment). #2609 was introduced to prevent a busy loop when pick_first is in TRANSIENT_FAILURE, and the resolver always returns the result immediately. However, making the resolver only return once caused pick_first to never update after going from READY to IDLE when a connection drops. This fixes that by making
exitIdleuse the most recent address list. This will result in some wasted work if the address list is stale, but ifexitIdleis called there should also be a resolver update pending, so it will be eventually consistent.