Skip to content

grpc-js: pick_first: fix happy eyeballs and reresolution in sticky TF mode#2602

Merged
murgatroid99 merged 2 commits intogrpc:@grpc/grpc-js@1.9.xfrom
murgatroid99:grpc-js_pick_first_sticky_tf_reresolve
Oct 19, 2023
Merged

grpc-js: pick_first: fix happy eyeballs and reresolution in sticky TF mode#2602
murgatroid99 merged 2 commits intogrpc:@grpc/grpc-js@1.9.xfrom
murgatroid99:grpc-js_pick_first_sticky_tf_reresolve

Conversation

@murgatroid99
Copy link
Copy Markdown
Member

This fixes two aspects of the pick_first LB policy's behavior while in sticky TF mode:

  1. When it gets an address update, it should do a happy eyeballs pass. Instead it was skipping that for some reason.
  2. When it enters sticky TF mode, it requests address reresolution, but after that, if it stays in sticky TF mode, there is no trigger to request reresolution again, potentially leading to a perpetually stale address list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants