grpc-js: Implement pick_first sticky TF and address list shuffling#2511
Merged
murgatroid99 merged 2 commits intogrpc:masterfrom Jul 31, 2023
Merged
grpc-js: Implement pick_first sticky TF and address list shuffling#2511murgatroid99 merged 2 commits intogrpc:masterfrom
murgatroid99 merged 2 commits intogrpc:masterfrom
Conversation
gnossen
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the non-xDS parts of gRFC A62. I also took this as an opportunity to simplify some aspects of the pick_first LB policy implementation.
The new tests in
test-pick-first.tsprimarily test how the LB policy responds to connectivity state transitions and address list updates, because I think that's the trickiest part of the behavior. There are also a few tests specifically of the address list randomization functionality.I omitted the environment variable protection for the address list randomization option because I believe it is sufficiently tested by the new tests.